Skip to content

Conversation

@floriankozikowski
Copy link
Contributor

Context of the PR

fixes issue #290

Contributions of the PR

changes _validate_data with validate_data
with sklearn.utils.validation import validate_data

Checks before merging PR

n/a

  • added documentation for any new feature
  • added unit tests
  • edited the what's new (if applicable)

@mathurinm
Copy link
Collaborator

@floriankozikowski thanks for the PR, we have updated main to fix other failing tests, so you need to git pull upstream main to integrate these changes, then git push for the UT to run with the correct changes

@mathurinm
Copy link
Collaborator

@floriankozikowski I guess in the requirements (that are inside pyproject.toml) we need to require sklearn >= 1.6 now since validate_data did not exist before ?

See https://scikit-learn.org/stable/modules/generated/sklearn.utils.validation.validate_data.html

@mathurinm mathurinm merged commit 994c5fc into scikit-learn-contrib:main Apr 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants