MNT - fix regression introduced in #270

[Badr-MOUFAD]

Context of the PR

fixes #302,
The regression is caused (after #270) by executing an extra initialization of the datafit with uncompiled datafit

Contributions of the PR

• remove unnecessary initialization of the datafit

Check it fixed

import time
from skglm import Lasso
from libsvmdata import fetch_libsvm

X, y = fetch_libsvm("news20.binary")
alpha = abs(X.T @ y).max() / len(y) / 2
model = Lasso(alpha=alpha, fit_intercept=False, tol=1e-12)

# cache compilation
t0 = time.time()
model.fit(X, y)
print("Initial fit:", time.time() - t0)

for _ in range(2):
    t0 = time.time()
    model.fit(X, y)
    print("Time to fit:", time.time() - t0)

# output
# Initial fit: 2.6478769779205322
# Time to fit: 0.20598602294921875
# Time to fit: 0.22588682174682617

Checks before merging PR

• [ ] added documentation for any new feature
• [ ] added unit tests
• [ ] edited the what's new (if applicable)

[Badr-MOUFAD]

back to top 💪

[mathurinm]

Thanks heaps @Badr-MOUFAD, super nice catch

Side note: If you find a way to automatically test for non regression in every PR (eg exactly on this example, check that solving time does not increase), that may be super nice