Skip to content

MNT - fix regression introduced in #270 #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

MNT - fix regression introduced in #270 #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725f8b3
rm unnecessary init
Badr-MOUFAD Apr 29, 2025
fec8100
stale commit
Badr-MOUFAD Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions skglm/estimators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,6 @@ def _glm_fit(X, y, model, datafit, penalty, solver):

n_samples, n_features = X_.shape

if issparse(X):
datafit.initialize_sparse(X_.data, X_.indptr, X_.indices, y)
else:
datafit.initialize(X_, y)

# if model.warm_start and hasattr(model, 'coef_') and model.coef_ is not None:
if solver.warm_start and hasattr(model, 'coef_') and model.coef_ is not None:
if isinstance(datafit, QuadraticSVC):
Expand Down