test(ifup, ifdown): Require cmd for completions #1533
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
reviewed
Dec 30, 2025
Owner
scop
left a comment
scop
left a comment
There was a problem hiding this comment.
LGTM, pre-approved with the test/test-cmd-list.txt issue addressed.
| ) | ||
| @pytest.mark.xfail(in_container(), reason="Probably fails in a container") | ||
| @pytest.mark.complete("ifdown ") | ||
| @pytest.mark.complete("ifdown ", require_cmd=True) |
Owner
There was a problem hiding this comment.
Needs an entry in test/test-cmd-list.txt, see CI fail.
Collaborator
Author
There was a problem hiding this comment.
Forgot to setup pre-commit... updated
fedora 43 doesn't seem to have ifup. Presumably it didn't fail in CI because we have an xfail for containers.
yedayak
force-pushed
the
ifupdown-require-cmd
branch
from
9cec709 to
3bf88fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fedora 43 doesn't seem to have ifup. Presumably it didn't fail in CI because we have an xfail for containers.