Skip to content

test(ifup, ifdown): Require cmd for completions #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yedayak merged 1 commit into from
Dec 30, 2025
+3 −2
Merged

test(ifup, ifdown): Require cmd for completions #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/t/test_ifdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class TestIfdown:
reason="There won't be any configured interfaces without network",
)
@pytest.mark.xfail(in_container(), reason="Probably fails in a container")
@pytest.mark.complete("ifdown ")
@pytest.mark.complete("ifdown ", require_cmd=True)
Copy link
Owner

@scop scop Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an entry in test/test-cmd-list.txt, see CI fail.

Copy link
Collaborator Author

@yedayak yedayak Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to setup pre-commit... updated

def test_1(self, completion):
assert completion

Expand Down
2 changes: 1 addition & 1 deletion test/t/test_ifup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class TestIfup:
reason="There won't be any configured interfaces without network",
)
@pytest.mark.xfail(in_container(), reason="Probably fails in a container")
@pytest.mark.complete("ifup ")
@pytest.mark.complete("ifup ", require_cmd=True)
def test_1(self, completion):
assert completion

Expand Down
1 change: 1 addition & 0 deletions test/test-cmd-list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ hwclock
iconv
identify
idn
ifdown
ifstat
iftop
ifup
Expand Down