feat: reth-scroll crates #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
feat/reth-scroll
branch
2 times, most recently
from
cdd8185 to
6c120a1
Compare
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
feat/reth-scroll
branch
from
6c120a1 to
a667eae
Compare
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
commented
Nov 19, 2024
greged93
commented
Nov 19, 2024
Merged
frisitano
previously approved these changes
Nov 21, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks great, thanks! Left some minor comments inline. Once comments are answered / addressed we can merge.
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Thegaram
reviewed
Nov 22, 2024
Signed-off-by: Gregory Edison <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduces the
scrollfeature flag and ScrollAccountchanges. The following changes are implemented:reth-scroll-*crates: introduces 4 Scroll related crates, which will accumulate as much changes as possible, in order to limit diff with upstream.Accountextending fields:code_sizeandposeidon_code_hashare added on the Ethereum account. These fields are needed for the computation of the state root.ScrollStateProviderDatabase: a storage provider that implements therevm::Databasetrait and will thus be used during execution when thescrollfeature flag is used. It caches all Scroll added fields for touched accounts during execution and can be used to build theScrollBundleStatefrom arevm::BundleState.Notes
// TODO (scroll): .... These were added in order to make the current changes satisfy allclippychecks and will be updated in subsequent PR's related to theAccountchanges.Cargo.lockfile.Builds towards #7