feat: scroll account #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
greged93
force-pushed
the
feat/scroll-account
branch
2 times, most recently
from
8583350 to
d17f014
Compare
greged93
commented
Nov 25, 2024
greged93
commented
Nov 25, 2024
greged93
commented
Nov 25, 2024
greged93
commented
Nov 25, 2024
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
feat/scroll-account
branch
from
dc00745 to
1a6bb9d
Compare
Signed-off-by: Gregory Edison <[email protected]>
frisitano
reviewed
Nov 26, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good! I've left some comments in line. Regarding indentation of dependencies lets try and stay consistent with the formatting currently used in reth. Looks like there's a few Cargo.toml files in which we diverge. I also think we should not change the HashedPostState type. I would like to understand your reasoning for doing so. Also added comment around the pattern for finalization of the State<DB> I suspect we can simplify this but wanted to see from your perspective if there's a blocker to the proposed solution.
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
…countInfo` Signed-off-by: Gregory Edison <[email protected]>
greged93
commented
Nov 27, 2024
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
feat/scroll-account
branch
from
19efb8d to
d59038b
Compare
Signed-off-by: Gregory Edison <[email protected]>
frisitano
approved these changes
Nov 28, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good, left one comment inline in regards to doc comment change which I think we should revert unless there is good reason not to.
Collaborator
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates all changes made on accounts from #33. This PR should only be reviewed once #33 is merged.
Adds
test_createin the execution stage in order to test the runtime computation of the Scroll fields. The caching characteristic is already covered bytest_selfdestruct.Builds towards #7