Skip to content

Conversation

@frisitano
Copy link
Collaborator

Overview

This PR introduces the primitive binary Merkle Patricia trie components required for scroll.

WIP

@frisitano frisitano changed the base branch from main to scroll November 20, 2024 03:22
Copy link
Collaborator Author

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments inline that need to be addressed.

@frisitano frisitano marked this pull request as ready for review December 5, 2024 10:34
@frisitano frisitano changed the title WIP: Introduce Scroll Binary Patricia Merkle Trie Components Introduce Scroll Binary Patricia Merkle Trie Components Dec 5, 2024
Copy link

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits and a question

This was referenced Dec 7, 2024
@frisitano frisitano requested a review from greged93 December 7, 2024 14:25
greged93
greged93 previously approved these changes Dec 8, 2024
Copy link

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, otherwise lgtm!

Copy link

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit 883d508 into scroll Dec 8, 2024
41 checks passed
@frisitano frisitano deleted the feat/scroll-bmpt branch December 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants