feat: scroll l1 message transaction #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
commented
Nov 21, 2024
Thegaram
reviewed
Nov 22, 2024
greged93
force-pushed
the
feat/scroll-transaction
branch
from
5b01075 to
91c5b0d
Compare
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
…ilation Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
feat/scroll-transaction
branch
from
91c5b0d to
675c027
Compare
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
frisitano
previously approved these changes
Nov 28, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Left some minor comments inline. This can be merged once they are addressed.
Signed-off-by: Gregory Edison <[email protected]>
frisitano
approved these changes
Nov 28, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
All looks good. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Scroll L1 message transaction as a variant in the Reth primitive enum
Transaction.L1 message transaction doesn't require a bincode "bridge" implementation because it doesn't contain optionally serializable fields.
Builds towards #7