Don't share the image_kwargs for dask and imageio#294
Merged
LucaMarconato merged 6 commits intoscverse:mainfrom May 5, 2025
Merged
Don't share the image_kwargs for dask and imageio#294LucaMarconato merged 6 commits intoscverse:mainfrom
LucaMarconato merged 6 commits intoscverse:mainfrom
Conversation
Contributor
Author
|
I revert the fix for the coordinate system, since @LucaMarconato you already fixed it in #303 I'll also close the corresponding issue I opened earlier. So, there is only the "separate kwargs" issue remaining |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
===========================================
- Coverage 49.53% 38.75% -10.78%
===========================================
Files 26 26
Lines 2709 2709
===========================================
- Hits 1342 1050 -292
- Misses 1367 1659 +292
🚀 New features to boost your workflow:
|
LucaMarconato
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR related to the following issues: