Xenium conversion of indexes to str#314
Merged
LucaMarconato merged 4 commits intomainfrom Aug 14, 2025
Merged
Conversation
Member
Author
|
Also this small commit was needed: dda3ffb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.equalalso checks for the index values. They arestrforobscolumns fromAnnDataobjects, while they are range indices for pandas dataframes. This PR converts the indices of the latter tostr.Note that the index is never used downstream (we use the
instance_keycolumn instead), so an alternative approach would have been to change theassertstatements to have them compare the values of the columns, and not the indices.