Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1007,12 +1007,12 @@ private boolean isValidPeer(Row peerRow, boolean logIfInvalid) {
&& !peerRow.isNull("data_center")
&& peerRow.getColumnDefinitions().contains("rack")
&& !peerRow.isNull("rack")
&& peerRow.getColumnDefinitions().contains("tokens")
&& (!peerRow.isNull("tokens")
|| cluster
.configuration
.getQueryOptions()
.shouldConsiderZeroTokenNodesValidPeers());
&& peerRow.getColumnDefinitions().contains("tokens");

if (isValid && peerRow.isNull("tokens")) {
// Don't log invalid row for zero token nodes, but report it if it is configured so.
return cluster.configuration.getQueryOptions().shouldConsiderZeroTokenNodesValidPeers();
}
}
if (!isValid && logIfInvalid)
logger.warn(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,12 @@ static void run_with_null_peer_info(String columns, boolean expectPeer2, boolean
.extractingResultOf("getAddress")
.doesNotContain(node2Address);

assertThat(log).containsOnlyOnce(expectedError);
if (columns.equals("tokens")) {
// For zero token nodes driver does not log an error
assertThat(log).doesNotContain(expectedError);
} else {
assertThat(log).containsOnlyOnce(expectedError);
}
}
} finally {
cLogger.removeAppender(logs);
Expand Down
Loading