-
Notifications
You must be signed in to change notification settings - Fork 10
Add vector similarity functions integration tests #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add vector similarity functions integration tests #241
Conversation
|
The validator tests should pass after scylladb/scylladb#25993 is merged. You can run them locally with: |
61fb2c7 to
017b06c
Compare
|
Changelog:
It turned out the feature does not work properly if the SELECT does not contain whole primary key. Furthermore I believe the tests can be refactored as they're very similar. |
017b06c to
6d9555e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive integration tests for the vector_similarity() function in ScyllaDB. The tests validate that the function correctly returns similarity scores when used with ANN queries across different table schema configurations.
- Adds integration tests for the
vector_similarity()function across three different scenarios - Updates the
create_indexfunction to support additional options parameter for vector index configuration - Ensures existing tests continue to work by passing
Nonefor the new options parameter
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/validator/src/tests/vector_similarity.rs |
New test file containing three test cases for the vector_similarity function |
crates/validator/src/tests/mod.rs |
Registers the new vector_similarity test module |
crates/validator/src/common.rs |
Updates create_index function to accept optional configuration parameters |
crates/validator/src/tests/*.rs |
Updates existing test calls to pass None for the new options parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
302aaae to
e608a06
Compare
|
Changelog:
|
e608a06 to
33bd1aa
Compare
|
Changelog:
|
33bd1aa to
b290b35
Compare
|
Changelog:
|
Since the change we may create the indexes with different than default vector index parameters like e.g. 'similarity_function'.
Add tests to validate the results of vector similarity functions including: - `similarity_cosine` function returns proper results, - `similarity_euclidean` function returns proper results, - `similarity_dot_product` function returns proper results, - similarity function works well with multicolumn partition key, - similarity function works well with both partition and clustering key. Refs: scylladb/scylladb#25993
b290b35 to
40414e5
Compare
|
Changelog:
|
vector_similarity() function integration tests
This patch introduce the validator integration tests for the
vector_similarity()function added in ScyllaDB.Refs: scylladb/scylladb#25993