Merged
Conversation
Critical bit is set on the MSB
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
==========================================
- Coverage 81.64% 78.72% -2.92%
==========================================
Files 359 334 -25
Lines 86237 81038 -5199
==========================================
- Hits 70405 63801 -6604
- Misses 15832 17237 +1405
|
gpotter2
previously approved these changes
Feb 3, 2025
Member
gpotter2
left a comment
There was a problem hiding this comment.
Thanks for the PR. Tested this and it seems correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the RFC, "Critical (1 bit) - MUST be set to zero if the sender wants the recipient to skip this payload if it does not understand the payload type code in the Next Payload field of the previous payload. MUST be set to one if the sender wants the recipient to reject this entire message". The fields are laid out in big endian order, it means to set the bit to critical we have to set the MSB to 1.