Skip to content

Fix IKEv2 critical bit set #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpotter2 merged 2 commits into from
Feb 3, 2025
+3 −3
Merged

Fix IKEv2 critical bit set #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb9d02
Fix critical bit set
dmaciejak Jan 27, 2025
7c4da1b
Add unit test
gpotter2 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scapy/contrib/ikev2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ class IKEv2_Payload(_IKEv2_Packet):
name = "IKEv2 Payload"
fields_desc = [
ByteEnumField("next_payload", None, IKEv2PayloadTypes),
FlagsField("flags", 0, 8, ["critical"]),
FlagsField("flags", 0, 8, {0x80: "critical"}),
ShortField("length", None),
XStrLenField("load", "", length_from=lambda pkt: pkt.length - 4),
]
Expand Down
4 changes: 2 additions & 2 deletions test/contrib/ikev2.uts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ a[IKEv2_Transform].show()

= Build Ikev2 SA request packet

a = IKEv2(init_SPI="MySPI",exch_type=34)/IKEv2_SA(prop=IKEv2_Proposal())
assert raw(a) == b'MySPI\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00! "\x00\x00\x00\x00\x00\x00\x00\x00(\x00\x00\x00\x0c\x00\x00\x00\x08\x01\x01\x00\x00'
a = IKEv2(init_SPI="MySPI",exch_type=34)/IKEv2_SA(flags="critical", prop=IKEv2_Proposal())
assert raw(a) == b'MySPI\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00! "\x00\x00\x00\x00\x00\x00\x00\x00(\x00\x80\x00\x0c\x00\x00\x00\x08\x01\x01\x00\x00'

= Build advanced IKEv2

Expand Down
Loading