[liquid metrics] Adds items from Subscription object to tags #3189
Conversation
nick-Ag
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 1229 1229
Lines 24524 24524
Branches 5015 5020 +5
=======================================
Hits 19627 19627
Misses 4135 4135
Partials 762 762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| `partnerAction:${subscription.partnerAction}`, | ||
| `actionId:${subscription.ActionID}`, | ||
| `configId:${subscription.ConfigID}`, | ||
| `projectId:${subscription.ProjectID}`, | ||
| `subscriptionName:${subscription.name}`, | ||
| `subscriptionSubscribe:${subscription.subscribe}` |
There was a problem hiding this comment.
@nick-Ag - this could be expensive. Do we really need this data? If so how long?
There was a problem hiding this comment.
I think we should permanently collect these metrics to monitor any issues in this feature. Is there a way to project the cost impact of adding these tags?
There was a problem hiding this comment.
all metrics included here are of high cardinaility. I would recommend reaching out in #help-datadog for getting latest metric costs and estimating them.
There was a problem hiding this comment.
can we throw an error with unique erorr type and use our existing hc.metrics for capturing these metrics?
This PR adds new tags to the metrics tracked for Liquid Functions, including the projectId to narrow down metrics to users. This is a followup to #3024
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Successfully tested in staging - the tags come back as expected:
