Skip to content

[liquid metrics] Adds items from Subscription object to tags #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[liquid metrics] Adds items from Subscription object to tags #3189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/core/src/destination-kit/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,15 @@ export class Destination<Settings = JSONObject, AudienceSettings = JSONObject> {
const isBatch = Array.isArray(events)

if (options?.statsContext?.tags !== undefined) {
options.statsContext.tags = [...options.statsContext.tags, `partnerAction:${subscription.partnerAction}`]
options.statsContext.tags = [
...options.statsContext.tags,
`partnerAction:${subscription.partnerAction}`,
`actionId:${subscription.ActionID}`,
`configId:${subscription.ConfigID}`,
`projectId:${subscription.ProjectID}`,
`subscriptionName:${subscription.name}`,
`subscriptionSubscribe:${subscription.subscribe}`
Comment on lines +731 to +736
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-Ag - this could be expensive. Do we really need this data? If so how long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should permanently collect these metrics to monitor any issues in this feature. Is there a way to project the cost impact of adding these tags?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all metrics included here are of high cardinaility. I would recommend reaching out in #help-datadog for getting latest metric costs and estimating them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we throw an error with unique erorr type and use our existing hc.metrics for capturing these metrics?

]
}

const subscriptionStartedAt = time()
Expand Down
Loading