Skip to content

Conversation

mdkhan-tw
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Removing iam settings from kafka destination docs because we don't support IAM authentication for Kafka.

https://twilio-engineering.atlassian.net/browse/STRATCONN-6172

Testing

Performed cloud stage deploy https://github.com/segmentio/action-destinations/actions/runs/18278506656, verification pending.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@itsarijitray
Copy link
Contributor

Changes looks good. Make sure to test on stage. We will also have to update tests.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this assuming no one is using this feature in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants