Skip to content

Removing IAM authentication from kafka settings #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −55
Open

Removing IAM authentication from kafka settings #3337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0284987
removing not applicable settings implementation
mdkhan-tw Oct 6, 2025
89a5f75
removing IAM authentication mechanism for kafka
mdkhan-tw Oct 6, 2025
1f5e5ea
remove unused import
mdkhan-tw Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/destination-actions/src/destinations/kafka/generated-types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 1 addition & 26 deletions packages/destination-actions/src/destinations/kafka/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { DestinationDefinition } from '@segment/actions-core'
import type { Settings } from './generated-types'
import { validate, getTopics } from './utils'
import { DEPENDS_ON_CLIENT_CERT, DEPEONDS_ON_AWS, DEPENDS_ON_PLAIN_OR_SCRAM } from './depends-on'
import { DEPENDS_ON_CLIENT_CERT, DEPENDS_ON_PLAIN_OR_SCRAM } from './depends-on'
import send from './send'

const destination: DestinationDefinition<Settings> = {
Expand Down Expand Up @@ -36,7 +36,6 @@ const destination: DestinationDefinition<Settings> = {
{ label: 'Plain', value: 'plain' },
{ label: 'SCRAM-SHA-256', value: 'scram-sha-256' },
{ label: 'SCRAM-SHA-512', value: 'scram-sha-512' },
// { label: 'AWS IAM', value: 'aws' },
{ label: 'Client Certificate', value: 'client-cert-auth' }
],
default: 'plain'
Expand All @@ -57,30 +56,6 @@ const destination: DestinationDefinition<Settings> = {
required: false,
depends_on: DEPENDS_ON_PLAIN_OR_SCRAM
},
accessKeyId: {
label: 'AWS Access Key ID',
description:
'The Access Key ID for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism.',
type: 'string',
required: false,
depends_on: DEPEONDS_ON_AWS
},
secretAccessKey: {
label: 'AWS Secret Key',
description:
'The Secret Key for your AWS IAM instance. Must be populated if using AWS IAM Authentication Mechanism.',
type: 'password',
required: false,
depends_on: DEPEONDS_ON_AWS
},
authorizationIdentity: {
label: 'AWS Authorization Identity',
description:
'AWS IAM role ARN used for authorization. This field is optional, and should only be populated if using the AWS IAM Authentication Mechanism.',
type: 'string',
required: false,
depends_on: DEPEONDS_ON_AWS
},
ssl_enabled: {
label: 'SSL Enabled',
description: 'Indicates if SSL should be enabled.',
Expand Down
17 changes: 0 additions & 17 deletions packages/destination-actions/src/destinations/kafka/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ export const serializeKafkaConfig = (settings: Settings): string => {
mechanism: settings.mechanism,
username: settings.username,
password: settings.password,
accessKeyId: settings.accessKeyId,
secretAccessKey: settings.secretAccessKey,
authorizationIdentity: settings.authorizationIdentity,
ssl_ca: settings.ssl_ca,
ssl_cert: settings.ssl_cert,
ssl_key: settings.ssl_key,
Expand Down Expand Up @@ -64,13 +61,6 @@ const getKafka = (settings: Settings) => {
password: settings.password,
mechanism: settings.mechanism
} as SASLOptions
case 'aws':
return {
accessKeyId: settings.accessKeyId,
secretAccessKey: settings.secretAccessKey,
authorizationIdentity: settings.authorizationIdentity,
mechanism: settings.mechanism
} as SASLOptions
default:
return undefined
}
Expand Down Expand Up @@ -118,13 +108,6 @@ export const validate = (settings: Settings) => {
400
)
}
if (['aws'].includes(settings.mechanism) && (!settings.accessKeyId || !settings.secretAccessKey)) {
throw new IntegrationError(
'AWS Access Key ID and AWS Secret Key are required for AWS authentication mechanism',
'SASL_AWS_PARAMS_MISSING',
400
)
}
if (['client-cert-auth'].includes(settings.mechanism) && (!settings.ssl_key || !settings.ssl_cert)) {
throw new IntegrationError(
'SSL Client Key and SSL Client Certificate are required for Client Certificate authentication mechanism',
Expand Down
Loading