Skip to content

Conversation

@MichaelGHSeg
Copy link
Collaborator

@MichaelGHSeg MichaelGHSeg commented Nov 22, 2024

  • I've included a changeset (psst. run yarn changeset. Read about changesets here).

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: becfdc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

paths: ['.yarn/cache/']

- label: '[Browser] Lint + Test'
key: browser-lint-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if incomplete, but we probably need to set COVERAGE=true as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Had thought that was set at the top of the file.

@MichaelGHSeg MichaelGHSeg requested a review from silesky December 17, 2024 21:45
silesky
silesky previously approved these changes Dec 17, 2024
@MichaelGHSeg MichaelGHSeg merged commit c3dbd52 into master Dec 17, 2024
8 checks passed
@MichaelGHSeg MichaelGHSeg deleted the MichaelGHSeg/gh_code_upload branch December 17, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants