Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Mar 19, 2025

Support:

{
 type: '...', // e.g. 'interaction'
 timestamp: '2025-03-18T20:27:01.459Z', // added
 anonymousId: '12345' // added
 data: { ... }
}

@silesky silesky requested a review from didiergarcia March 19, 2025 19:15
@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 637b309

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-signals Minor
@segment/analytics-signals-runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title Add anonymousId and timestamp to signalData Add anonymousId and timestamp to web signalData Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (83c25bb) to head (07aefe2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...als/signals/src/core/middleware/user-info/index.ts 16.66% 5 Missing ⚠️
...kages/signals/signals/src/plugin/signals-plugin.ts 50.00% 2 Missing ⚠️
...ckages/signals/signals/src/core/signals/signals.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   83.86%   83.79%   -0.08%     
==========================================
  Files         221      222       +1     
  Lines        5877     5888      +11     
  Branches     1344     1344              
==========================================
+ Hits         4929     4934       +5     
- Misses        948      954       +6     
Flag Coverage Δ
browser 92.27% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

didiergarcia
didiergarcia previously approved these changes Mar 19, 2025
@silesky silesky merged commit 6753b4b into master Mar 20, 2025
8 checks passed
@silesky silesky deleted the add-anonid-timestamp-to-signals branch March 20, 2025 16:34
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants