Fix filtering of non-consented device mode integrations #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f14091 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
=======================================
Coverage 91.19% 91.19%
=======================================
Files 163 163
Lines 4383 4383
Branches 1052 1052
=======================================
Hits 3997 3997
Misses 386 386
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelGHSeg
approved these changes
Oct 24, 2025
Merged
aalkhodiry
added a commit
to nayla-finance/analytics-next
that referenced
this pull request
Nov 2, 2025
* Small repo chores (segmentio#1289) * Migrate consent integration tests to Playwright (segmentio#1292) Co-authored-by: Neelkanth Kaushik <[email protected]> * Fix jira automation (segmentio#1301) * Update Node.js version to ^20 across the repository (segmentio#1307) * Expose BaseUserTraits (segmentio#1306) * change to minor release (segmentio#1310) * Version Packages (segmentio#1309) * Update to use new signals specification (segmentio#1311) * Move signals packages out of repo (segmentio#1315) * Add architecture documentation (segmentio#1319) * Update dependencies for snyk issues (segmentio#1321) * Remove github signals docs folder (segmentio#1322) * Fix filtering of non-consented device mode integrations (segmentio#1328) * Version Packages (segmentio#1329) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update RELEASING.md on how to rotate npm tokens (segmentio#1330) --------- Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: Neelkanth Kaushik <[email protected]> Co-authored-by: Chenxiang Zhang <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1326
When using opt-in consent mode with multiple non-consented integrations, only the last integration would be filtered.
This PR fixes the bug by filtering on
cdnSettingsCopy.remotePluginsyarn changeset. Read about changesets here).