retry transaction up to 3 times for usb host#159
Merged
sekigon-gonnoc merged 3 commits intosekigon-gonnoc:mainfrom Mar 7, 2025
Merged
retry transaction up to 3 times for usb host#159sekigon-gonnoc merged 3 commits intosekigon-gonnoc:mainfrom
sekigon-gonnoc merged 3 commits intosekigon-gonnoc:mainfrom
Conversation
Contributor
Author
|
@sekigon-gonnoc PR is ready for ready, let me know if this makes sense to you. retrying failed transaction 3 times before marking it as failed is rather common with other native controller as well. |
Contributor
Author
|
Thank you |
|
yay thanks @sekigon-gonnoc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing with pio-usb as host with hub device, when plugging and unplugging device from hub, the bus can have some interruption and can cause on-going transaction to fail. Not all class driver handle failed transaction nicely. However, most of the time, a couple of retry in the next frame would solve the issue without escalate it to driver (to re-schedule transfer).
This should help to address #149 and #148. I will mark this as ready after doing more entensive tests. If anyone can help to provide feedback, that would be great.
related issue: hathach/tinyusb#2994 enhance hub driver and control transfer to also re-schedule failed transfer as well.
PS: Testing more and it does improve hub with multiple plug/unplug. Therefore this is ready for review
@tannewt @ladyada