Skip to content

feat: clean node_modules before building subgraph #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vplasencia merged 9 commits into from
Nov 26, 2024
Merged

feat: clean node_modules before building subgraph #884

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b541fe9
feat(cli): remove @semaphore-protocol/cli prepublish script
0xshikhar Oct 23, 2024
bd13fb1
refactor(cli): add comment
0xshikhar Oct 23, 2024
297833e
refactor(cli): create seperate file for removePrePublishScript function
0xshikhar Oct 23, 2024
5da0dec
refactor(cli): using updatedPackageJsonContent var instead of calling…
0xshikhar Oct 23, 2024
32190e7
Merge branch 'semaphore-protocol:main' into main
0xshikhar Oct 24, 2024
656f01d
fix(subgraph): clean node_modules before building subgraph
0xshikhar Oct 24, 2024
8393458
refactor(subgraph): fix: test typo
0xshikhar Oct 31, 2024
0fbd1fc
refactor(subgraph): refactor: remove nohoist
0xshikhar Nov 21, 2024
b6767ec
refactor(subgraph): refactor: workspaces structure
0xshikhar Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"scripts": {
"build": "yarn build:libraries && yarn build:subgraph && yarn build:website && yarn build:docs",
"build:libraries": "yarn workspaces foreach -Apt --no-private run build",
"build:subgraph": "yarn workspace semaphore-subgraph build:sepolia",
"clean:subgraph": "rimraf apps/subgraph/node_modules",
"build:subgraph": "yarn clean:subgraph && yarn workspace semaphore-subgraph build:sepolia",
"build:website": "yarn workspace semaphore-website build",
"build:docs": "yarn workspace semaphore-docs build",
"compile:contracts": "yarn workspace semaphore-contracts compile",
Expand All @@ -27,6 +28,7 @@
"version:publish": "scripts/publish.ts",
"version:release": "changelogithub",
"clean": "scripts/clean-apps.ts && scripts/clean-packages.ts && yarn clean:cli-templates && rimraf node_modules",
"clean:branch": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +",
"clean:cli-templates": "scripts/clean-cli-templates.ts",
"remove:stable-version-field": "scripts/remove-stable-version-field.ts && yarn format:write",
"precommit": "lint-staged",
Expand All @@ -45,11 +47,16 @@
"proof-of-membership",
"monorepo"
],
"workspaces": [
"apps/*",
"packages/*",
"packages/contracts/contracts"
],
"workspaces": {
Copy link
Member

@vplasencia vplasencia Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this section as it was before?

"workspaces": [
        "apps/*",
        "packages/*",
        "packages/contracts/contracts"
    ],

Copy link
Contributor Author

@0xshikhar 0xshikhar Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @vplasencia , done that change on the file. Let me know.

"packages": [
"packages/*",
"apps/*",
"packages/contracts/contracts"
],
"nohoist": [
"**/semaphore-subgraph/**"
]
},
"packageManager": "yarn@4.1.0",
"devDependencies": {
"@commitlint/cli": "^18.6.1",
Expand Down