feat: clean node_modules before building subgraph #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to remove the prepublish script from the scripts object of the package.json file of every cli template when the template is downloaded using the CLI. BREAKING CHANGE: n
… readFileSync again
feat: clean node_modules before building subgraph
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
vplasencia
reviewed
Oct 30, 2024
Member
vplasencia
left a comment
vplasencia
left a comment
There was a problem hiding this comment.
Hey @0xshikhar thank you very much for this PR. I just left one comment.
vplasencia
reviewed
Nov 3, 2024
vplasencia
requested changes
Nov 25, 2024
package.json
Outdated
| "packages/*", | ||
| "packages/contracts/contracts" | ||
| ], | ||
| "workspaces": { |
Member
There was a problem hiding this comment.
Could you keep this section as it was before?
"workspaces": [
"apps/*",
"packages/*",
"packages/contracts/contracts"
],
Contributor
Author
There was a problem hiding this comment.
Sure @vplasencia , done that change on the file. Let me know.
vplasencia
approved these changes
Nov 26, 2024
Member
vplasencia
left a comment
vplasencia
left a comment
There was a problem hiding this comment.
Great work @0xshikhar! 🚀
Thank you very much!
7 tasks
FaezehShakouri
pushed a commit
to FaezehShakouri/semaphore
that referenced
this pull request
Feb 1, 2025
…#884) * feat(cli): remove @semaphore-protocol/cli prepublish script The idea is to remove the prepublish script from the scripts object of the package.json file of every cli template when the template is downloaded using the CLI. BREAKING CHANGE: n * refactor(cli): add comment * refactor(cli): create seperate file for removePrePublishScript function * refactor(cli): using updatedPackageJsonContent var instead of calling readFileSync again * fix(subgraph): clean node_modules before building subgraph * refactor(subgraph): fix: test typo * refactor(subgraph): refactor: remove nohoist * refactor(subgraph): refactor: workspaces structure
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(subgraph): clean node_modules before building subgraph
Related Issue(s)
Closes: Issue#876
Other information
Checklist
yarn formatandyarn lintwithout getting any errors