Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Jan 23, 2025

  • Add new Traits WithUniqueId and WithValueAndTimestamp
  • implement WithUniqueId and WithValueAndTimestamp for SignedReceipt
  • ReceiptWithState generic over the receipt
  • RAVRequest generic over receipt
  • Manager generic over receipt (can only collect receipts for SignedReceipt for now)
  • Checklist generic over receipt
  • Functions that previously needed timestamp_ns and value from receipt now uses generic with WithValueAndTimestamp bounds

@gusinacio gusinacio force-pushed the gustavo/manager-generic-for-receipt branch from ff77d66 to 9d0e55e Compare January 23, 2025 16:52
@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12935469436

Details

  • 65 of 72 (90.28%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 81.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/receipt/checks.rs 18 19 94.74%
tap_core/src/receipt/receipt_sol.rs 3 6 50.0%
tap_core/src/signed_message.rs 6 9 66.67%
Totals Coverage Status
Change from base Build 12932747123: -0.3%
Covered Lines: 1044
Relevant Lines: 1286

💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/manager-generic-for-receipt branch from 9d0e55e to cd14047 Compare January 23, 2025 16:55
@gusinacio gusinacio force-pushed the gustavo/manager-generic-for-receipt branch from 012b18e to b167ee2 Compare January 23, 2025 18:14
@gusinacio gusinacio force-pushed the gustavo/manager-generic-for-receipt branch from b167ee2 to 677b84c Compare January 23, 2025 18:16
@gusinacio gusinacio merged commit 25a3316 into main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants