chore(eip712): remove draft benchmark code w/ verify method #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Livesey <[email protected]>
suchapalaver
force-pushed
the
suchapalaver/remove-unused-draft-benchmark-work
branch
from
208c6e5 to
151c005
Compare
Pull Request Test Coverage Report for Build 14846247629Details
💛 - Coveralls |
TypeLevelConsoli
approved these changes
May 5, 2025
neithanmo
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmarking code - I believe - was drafting out some verifiability work, but it isn't documented and it contains a bug. Since this was never part of any The Graph production code proposing to root and branch bin this now.
Signed off by: Joseph Livesey [email protected]