fix: improve receipt deduplication with signature normalization #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
force-pushed
the
suchapalaver/improve-receipt-deduplication-with-signature-normalization
branch
from
1b5def8 to
87ceff7
Compare
Pull Request Test Coverage Report for Build 14889332084Details
💛 - Coveralls |
Signed-off-by: Joseph Livesey <[email protected]>
Signed-off-by: Joseph Livesey <[email protected]>
Signed-off-by: Joseph Livesey <[email protected]>
suchapalaver
force-pushed
the
suchapalaver/improve-receipt-deduplication-with-signature-normalization
branch
from
87ceff7 to
cc8e00f
Compare
TypeLevelConsoli
approved these changes
May 7, 2025
|
|
||
| #[rstest] | ||
| #[test] | ||
| fn test_signature_malleability_vulnerability( |
There was a problem hiding this comment.
I really appreciate the comments in this test case! Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the security of receipt deduplication by making it resistant to signature malleability attacks. The implementation now identifies receipts based on their message content and recovered signer, rather than just raw signature bytes.
Changes
unique_hashmethod toEip712SignedMessagethat combines message content and signer addresscheck_signatures_uniqueto use this malleation-resistant approach