Skip to content

Bump Verify.SourceGenerators from 2.2.0 to 2.5.0#304

Merged
agocke merged 3 commits intomainfrom
dependabot/nuget/Verify.SourceGenerators-2.5.0
Apr 8, 2026
Merged

Bump Verify.SourceGenerators from 2.2.0 to 2.5.0#304
agocke merged 3 commits intomainfrom
dependabot/nuget/Verify.SourceGenerators-2.5.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Jan 25, 2026

  • Investigate CI build failures (17 snapshot mismatches in Serde.Generation.Test)
  • Understand the snapshot format change in Verify.SourceGenerators 2.5.0 (diagnostic format now includes source context in Location and nested Descriptor object)
  • Run tests locally to generate new snapshots
  • Update all 17 failing verified snapshot files
  • Validate all 155 tests pass (77 generation + 78 serde)
  • Run final validation (code review and CodeQL both passed)

@dependabot dependabot bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Jan 25, 2026
@dependabot dependabot bot force-pushed the dependabot/nuget/Verify.SourceGenerators-2.5.0 branch 3 times, most recently from 6c9085c to e9dbba3 Compare January 29, 2026 03:45
@dependabot dependabot bot force-pushed the dependabot/nuget/Verify.SourceGenerators-2.5.0 branch 2 times, most recently from 0621f6e to ff8e50d Compare February 9, 2026 18:48
---
updated-dependencies:
- dependency-name: Verify.SourceGenerators
  dependency-version: 2.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Verify.SourceGenerators-2.5.0 branch from ff8e50d to 29c3572 Compare February 17, 2026 05:56
@agocke
Copy link
Copy Markdown
Collaborator

agocke commented Apr 6, 2026

@copilot can you take a look at these failures?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 6, 2026

@copilot can you take a look at these failures?

The CI failure was caused by Verify.SourceGenerators 2.5.0 changing the diagnostic snapshot format — the new version includes source code context in the Location field and uses a nested Descriptor object instead of flat diagnostic properties. This caused all 17 snapshot-based tests in Serde.Generation.Test to fail with mismatches between the received and verified .txt files.

Fixed in 0aa7053 by regenerating all 17 verified snapshot files to match the new format. All 155 tests now pass.

Copilot AI requested a review from agocke April 6, 2026 18:25
@agocke agocke merged commit 6664ddd into main Apr 8, 2026
1 check passed
@agocke agocke deleted the dependabot/nuget/Verify.SourceGenerators-2.5.0 branch April 8, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants