DAVE support by beer-psi · Pull Request #291 · serenity-rs/songbird

beer-psi · 2026-02-22T16:11:25Z

Closes #293

Sending voice packets now mostly works.

Receiving is not very heavily tested, and there are a bunch of annoyances:

~~Passthrough (unencrypted) voice packets will still go into the decryption code path, so you will get error logs like:~~

ERROR davey::cryptor::frame_processors: no magic marker

~~The UDP receiving task is separate from the gateway task, so decrypting the first few packets will fail because the key ratchets haven't been set up yet. This should probably be fixed with a buffer?~~ Packets that are received before the key ratchets are set up are silently dropped.
SpeakingStateUpdate events are apparently not fired consistently

~~The PR is still unreviewed, but~~ if your bot needs this it's been tested and working on a few bots. If you use serenity-next, you may want to depend on jtscuba's fork of this PR instead, which depends on serenity-next: https://github.com/jtscuba/songbird/tree/davey

TODO

serenity-voice-model will need to be updated on crates.io to add the missing dave_protocol_version field in SessionDescription.
Add a way to retrieve the voice privacy code and the verification codes (e.g. Call::voice_privacy_code?)

this doesn't matter as both of the only cipher modes doesn't have any prefixes, but still

This is currently a PR over at serenity-rs/songbird#291, but I'd like to cut an alpha release to battle test this on my bots. Also upgrade PyO3 to 0.28.2, and maturin to 1.12 for the namespace package support.

beer-psi · 2026-02-25T11:02:09Z

I'm not sure how I can surface the voice privacy code up to the Driver interface in the existing architecture. Could I add a new CoreEvent::VoicePrivacyCode or something of that sort and then emit the event when a DAVE transition is executed (which is when the code is changed)?

This is due to a race condition between buffered gateway events (all events except Hello, Ready, Resumed before SessionDescription are buffered) and newly incoming gateway events. Due to tokio::select! [polling branches in random order](https://docs.rs/tokio/latest/tokio/macro.select.html#fairness), DaveMlsProposals can be processed before ClientsConnect, which is where the list of connected users are sent. Ensuring that all buffered events are processed first allows for the list of recognized user IDs to be properly populated.

…ailures.

Discord enforced DAVE (E2EE) protocol for all voice connections starting March 2, 2026. The voice gateway now rejects non-DAVE clients with close code 4017 ("E2EE/DAVE protocol required"). Switch songbird dependency from crates.io v0.5.0 to beerpsi-forks/songbird (davey branch) which implements DAVE protocol support via the `davey` crate and MLS-based key exchange. This fork is from PR serenity-rs/songbird#291. Ref: serenity-rs/songbird#291 https://claude.ai/code/session_01K2oMKKW55q1PFaipJhmwK8

tktcorporation · 2026-03-04T06:53:50Z

Thanks for the great work on this! I was able to get my library working by pointing to your fork in the meantime. I may not be in a position to contribute much directly, but please let me know if there’s anything I can do to help move this forward!

tdgroot · 2026-03-04T21:23:05Z

Works for me! 😃

Can be moved back to a normal dependency once serenity-rs/songbird#291 is in a published release

Discord now needs DAVE/E2EE for voice connection, PR in origin songbird upstream hasn't been merged, so swtich to beerpsi's fork to fix this Refs: serenity-rs/songbird#291

…ted before proceeding

Erk-

The changes looks good, ~~I have the comment about the unnecessary (as far as I can tell) atomic~~ (I was wrong there) and then there is some warning of unused values you get when you for example build the twilight example that needs to be cleaned up, but other than that it looks good.

src/driver/tasks/ws.rs

…ve DAVE session

Siydge · 2026-03-14T15:15:45Z

Tested, works great for me, no issues, tested with following override for others in need

[patch.crates-io]
songbird = { git = "https://github.com/beerpsi-forks/songbird", branch = "davey" }

…m for any reason

Achilleees · 2026-03-17T01:54:02Z

Thanks for this guys. Tested and works great! Looking forward to the merge.

krywicki · 2026-03-24T23:37:55Z

Ran in to trouble with DAVE protocol on my sound bot. I've added this as a songbird patch and tested it. It works great! 🙌

* Discord E2EE/DAVE Discord is now enforcing DAVE (Discord Audio Video Encryption) for voice now. There is a [PR](serenity-rs/songbird#291) to support the protocol. The changes here will add that PR as a temporary patch. * Sqlite types fix Updates to rusqlite no longer support u64 types. This changes the types to i64 now.

* Discord E2EE/DAVE Discord is now enforcing DAVE (Discord Audio Video Encryption) for voice now. There is a [PR](serenity-rs/songbird#291) to support the protocol. The changes here will add that PR as a temporary patch. * Sqlite types fix Updates to rusqlite no longer support u64 types. This changes the types to i64 now. Co-authored-by: krywicki <joseph.krywicki@gmail.com>

beer-psi added 5 commits February 20, 2026 11:52

Initial Davey support (incomplete)

98db5da

stage 2: sending voice works

16e8ad4

switch to serenity next branch, since the voice model there is fixed

e7b3ea2

fix: account for first_payload_byte when DAVE encrypting

6284f21

this doesn't matter as both of the only cipher modes doesn't have any prefixes, but still

receiving support

8d16b68

beer-psi marked this pull request as draft February 22, 2026 16:12

beer-psi added 3 commits February 23, 2026 20:09

remove finished todo

cb243e6

switch to tokio::sync::RwLock since that can be used in both sync/async

078a449

don't block on lock in udp rx

c371dfe

beer-psi added 4 commits February 26, 2026 14:06

Keep track of recognized user IDs for proposal verification.

fba78d0

Also store transitions from DaveMlsWelcome.

49ac577

Fix binary message decoding for tokio-websockets

e5e897d

beer-psi marked this pull request as ready for review February 27, 2026 12:47

beer-psi added 6 commits February 27, 2026 20:33

Verify padding is PKCS7 before unpadding.

a3d3f7e

Ignore decryption error for packets that don't look like DAVE

10f0d9f

Switch to serenity-rs/voice-model

5c00907

Remove workaround for missing sequence numbers.

bdf5503

Downgrade DAVE decryption failures to warn! to match RTP decryption f…

eb98010

…ailures.

Update to davey 0.1.2

2519587

foylaou mentioned this pull request Mar 4, 2026

Switch songbird to DAVE-enabled fork for Discord E2EE voice support foylaou/aoede-Foy-#7

Merged

4 tasks

SharkBaitDLS added a commit to SharkBaitDLS/my-man that referenced this pull request Mar 6, 2026

Switch to DAVE-enabled fork of songbird temporarily

6c5fff0

Can be moved back to a normal dependency once serenity-rs/songbird#291 is in a published release

nwerosama mentioned this pull request Mar 7, 2026

E2EE/DAVE protocol required #293

Open

reiyw added a commit to reiyw/songbird that referenced this pull request Mar 7, 2026

Apply serenity-rs#291 patch

04ba01e

Kronicaler added a commit to Kronicaler/songbird that referenced this pull request Mar 7, 2026

Copy dave support from serenity-rs#291

e0ce937

phoxwupsh mentioned this pull request Mar 9, 2026

[Bug] 超過38分鐘的歌曲會被中斷播放 phoxwupsh/turto#29

Open

blthayer mentioned this pull request Mar 10, 2026

Error joining voice channels: "failed to join voice channel: establishing connection failed" blthayer/disquip-bot-rs#20

Open

This comment was marked as off-topic.

Sign in to view

phoxwupsh mentioned this pull request Mar 12, 2026

DAVE/E2EE support phoxwupsh/turto#30

Merged

Properly handle RTP payload padding + check if bodies are E2EE encryp…

653177e

…ted before proceeding

Erk- requested changes Mar 14, 2026

View reviewed changes

src/driver/tasks/ws.rs Show resolved Hide resolved

beer-psi added 5 commits March 14, 2026 20:35

Fix compile warnings and propagate WsError when failing to reinitiali…

f27d662

…ve DAVE session

Don't touch the examples, oops

f027d22

Don't touch the examples, oops (2)

7a4123e

Run nightly rustfmt

a62b04a

Address clippy warnings

82cbeec

Erk- approved these changes Mar 14, 2026

View reviewed changes

beer-psi added 4 commits March 14, 2026 23:25

Update serenity-voice-model to 0.3

372e0a1

Completely drop encrypted packets if it's not possible to decrypt the…

e48257f

…m for any reason

unmagic the sequence

51ef9f9

Fix tests

4c5c2b5

krywicki mentioned this pull request Mar 24, 2026

Patches in E2EE/DAVE protocol; Fixes sqlite types for tables krywicki/discord-soundboard-bot-rs#16

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAVE support#291

DAVE support#291
beer-psi wants to merge 28 commits intoserenity-rs:nextfrom
beerpsi-forks:davey

beer-psi commented Feb 22, 2026 •

edited

Loading

Uh oh!

beer-psi commented Feb 25, 2026

Uh oh!

tktcorporation commented Mar 4, 2026

Uh oh!

tdgroot commented Mar 4, 2026

Uh oh!

This comment was marked as off-topic.

Erk- left a comment •

edited

Loading

Uh oh!

Uh oh!

Siydge commented Mar 14, 2026

Uh oh!

Achilleees commented Mar 17, 2026

Uh oh!

krywicki commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

beer-psi commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

beer-psi commented Feb 25, 2026

Uh oh!

tktcorporation commented Mar 4, 2026

Uh oh!

tdgroot commented Mar 4, 2026

Uh oh!

This comment was marked as off-topic.

Erk- left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Siydge commented Mar 14, 2026

Uh oh!

Achilleees commented Mar 17, 2026

Uh oh!

krywicki commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

beer-psi commented Feb 22, 2026 •

edited

Loading

Erk- left a comment •

edited

Loading