Added AgenticServices helper #835
Draft
+323
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treblereel
force-pushed
the
agentic_helper
branch
2 times, most recently
from
2401aa7 to
61bd518
Compare
| .outputName("story") | ||
| .build()); | ||
| spy( | ||
| dev.langchain4j.agentic.AgenticServices.agentBuilder(CreativeWriter.class) |
| } | ||
| } | ||
|
|
||
| private static class AgentInvocationHandler implements InvocationHandler { |
There was a problem hiding this comment.
I think we already have something pretty similar on the agentic-langchain4j module. Is it doable to share the same class?
treblereel
force-pushed
the
agentic_helper
branch
2 times, most recently
from
21fa658 to
bfec4eb
Compare
fjtirado
reviewed
Oct 7, 2025
Comment on lines
36
to
38
| if (model instanceof HasAgenticScope<?> hasAgenticScope && inputClass.isEmpty()) { | ||
| return (T) hasAgenticScope.getAgenticScope(); | ||
| } |
There was a problem hiding this comment.
You should not do this change here, but in as (when inputclass is not empty) and asJavaObject (when inputclass is empty) methods of AgenticModel
fjtirado
reviewed
Oct 7, 2025
There was a problem hiding this comment.
This class should not be added, the change in convert should be done in asJavaObject
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
treblereel
force-pushed
the
agentic_helper
branch
from
bfec4eb to
18e031d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.