Skip to content

Conversation

treblereel
Copy link
Collaborator

No description provided.

@treblereel treblereel marked this pull request as draft September 29, 2025 22:24
@treblereel treblereel force-pushed the agentic_helper branch 2 times, most recently from 2401aa7 to 61bd518 Compare October 1, 2025 19:20
.outputName("story")
.build());
spy(
dev.langchain4j.agentic.AgenticServices.agentBuilder(CreativeWriter.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the FQCN

}
}

private static class AgentInvocationHandler implements InvocationHandler {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have something pretty similar on the agentic-langchain4j module. Is it doable to share the same class?

@treblereel treblereel force-pushed the agentic_helper branch 2 times, most recently from 21fa658 to bfec4eb Compare October 6, 2025 22:03
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
@fjtirado fjtirado self-requested a review October 8, 2025 07:44
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting pretty neat!

CreativeWriter creativeWriter =
spy(
AgenticServices.agentBuilder(CreativeWriter.class)
dev.langchain4j.agentic.AgenticServices.agentBuilder(CreativeWriter.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the FQCN

var styleEditor = newStyleEditor();

AgentsUtils.NovelCreator novelCreator =
io.serverlessworkflow.fluent.agentic.AgenticServices.of(AgentsUtils.NovelCreator.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places with FQCN.

AgentsUtils.NovelCreator novelCreator =
io.serverlessworkflow.fluent.agentic.AgenticServices.of(AgentsUtils.NovelCreator.class)
.flow(workflow("seqFlow").agent(creativeWriter).sequence(audienceEditor, styleEditor))
.build();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This DSL is looking pretty cool. We should do the same for FuncWorkflowBuilder, which is the one we are using on quarkus-flow next.

.flow(
workflow("humanInTheLoop")
.inputFrom(askSign)
// .tasks(tasks -> tasks.callFn(fn(askSign))) // TODO should work too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to track this?

}
}

private class AgentInvocationHandler implements InvocationHandler {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants