Skip to content

Conversation

tomwhite
Copy link
Contributor

This is an alternative to #367, which removes the vcf_header attribute and replaces it with vcf_meta_information as described in sgkit-dev/vcf-zarr-spec#29.

@coveralls
Copy link
Collaborator

coveralls commented May 13, 2025

Coverage Status

coverage: 98.192% (+0.007%) from 98.185%
when pulling 710ab89 on tomwhite:reduce-vcf-header
into 5d2bd3b on sgkit-dev:main.

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@tomwhite tomwhite force-pushed the reduce-vcf-header branch from 8b974de to 710ab89 Compare May 20, 2025 09:41
@tomwhite tomwhite marked this pull request as ready for review May 20, 2025 09:41
@jeromekelleher jeromekelleher added this pull request to the merge queue May 20, 2025
Merged via the queue into sgkit-dev:main with commit 928965e May 20, 2025
15 checks passed
@tomwhite tomwhite deleted the reduce-vcf-header branch May 20, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants