Add spirv target test coverage for vk::binding diagnostic on entry point parameters #9469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic warning 38010 for unsupported
vk::bindingattributes on entry point parameters was already implemented but lacked test coverage for the spirv target—the primary use case for Vulkan bindings.Changes
tests/diagnostics/entry-point-mod-errors.slangto include spirv target testingtests/diagnostics/vk-binding-entry-point-param-spirv.slangwith a focused test case matching the reported scenarioExample
Users compiling this code with
-target spirvnow see the diagnostic:The diagnostic correctly informs users that these attributes are unsupported on entry point parameters and will be ignored.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.