Skip to content

Add spirv target test coverage for vk::binding diagnostic on entry point parameters #9469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add spirv target test coverage for vk::binding diagnostic on entry point parameters #9469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f526071
Initial plan
Copilot Dec 22, 2025
42fa08c
Add spirv target test for vk::binding diagnostic on entry point param…
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/diagnostics/entry-point-mod-errors.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -entry computeMain -target cuda
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -entry computeMain -target metal
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -entry computeMain -target cpp
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -entry computeMain -target spirv
[shader("compute")]
[numthreads(1,1,1)]
void computeMain(
Expand Down
18 changes: 18 additions & 0 deletions tests/diagnostics/vk-binding-entry-point-param-spirv.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Test that vk::binding attributes on entry point parameters trigger a warning on spirv target
// This addresses the issue where vk::binding is ignored on entry point parameters

//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -entry main -target spirv

[numthreads(32, 1, 1)]
[shader("compute")]
void main(
// CHECK: ([[#@LINE+1]]): warning 38010: {{.*}}vk::binding{{.*}}a
[[vk::binding(/* binding */ 0, /* set */ 1)]]
StructuredBuffer<float> a,
// CHECK: ([[#@LINE+1]]): warning 38010: {{.*}}vk::binding{{.*}}b
[[vk::binding(/* binding */ 3, /* set */ 2)]]
RWStructuredBuffer<float> b,
)
{
b[0] = a[0];
}