Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflow for WebAssembly builds was refactored to use cmake with explicit source/build dirs (-S/-B) for both OpenCV and OpenCvSharpExtern, and cache restore/save entries were expanded to target specific OpenCV artifacts ( Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Cache as Cache
participant CMake as CMake
participant OpenCV as OpenCV Source
participant Contrib as opencv_contrib
participant Extern as OpenCvSharpExtern
participant NuGet as NuGet artifacts
GH->>Cache: restore caches (include, lib, libopencv.o)
GH->>CMake: configure OpenCV (-S OpenCV -B OpenCV/build, set OPENCV_EXTRA_MODULES_PATH)
CMake->>OpenCV: read source & contrib modules
CMake->>OpenCV: build (cmake --build)
CMake->>GH: install (cmake --install to output dirs)
GH->>CMake: configure Extern (-S src -B src/build)
CMake->>Extern: build Extern (cmake --build)
GH->>NuGet: copy built artifacts from src/build to nuget folder
GH->>Cache: save caches (include, lib, libopencv.o)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/wasm.yml:
- Around line 82-84: The OPENCV_EXTRA_MODULES_PATH currently uses a relative
path that assumes CMake is run from the build dir; update the emcmake cmake
invocation (the line with emcmake cmake -S opencv-${OPENCV_VERSION} -B
opencv-${OPENCV_VERSION}/build and the -DOPENCV_EXTRA_MODULES_PATH setting) to
point to the correct location by using an absolute path (e.g., resolve to
${GITHUB_WORKSPACE}/opencv_contrib-${OPENCV_VERSION}/modules or construct a path
relative to the repository root) so the modules path is correct when using -S/-B
from the workspace root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit