Update to latest flow commit, make voice-id configurable#3
Merged
ovistoica merged 2 commits intoshipclojure:mainfrom Feb 13, 2025
Merged
Update to latest flow commit, make voice-id configurable#3ovistoica merged 2 commits intoshipclojure:mainfrom
ovistoica merged 2 commits intoshipclojure:mainfrom
Conversation
…add arity-2 :transition fn, voice-id from secrets
ovistoica
requested changes
Feb 13, 2025
Collaborator
ovistoica
left a comment
ovistoica
left a comment
There was a problem hiding this comment.
The change looks very good! Thank you. I knew the voice-id was an issue and I had a personal todo to fix it.
Thank you for the time & effort on this, Florin! Very much appreciated!
I left a comment about ignoring clj-kondo which is not a wanted change. Please fix that and this can be merged
| /core/.idea/ | ||
| /core/core.iml | ||
| .idea/ | ||
| .clj-kondo/ |
Collaborator
There was a problem hiding this comment.
clj-kondo is important not to be added to ignore, as it contains rules for handling custom macros like defframe
Please revert to just ignoring .clj-kondo/.cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were needed to make the local and scenario examples work on my machine.
The hard-coded Eleven Labs voice ID was failing with 'Voice ID not found' error.
This change makes it configurable in secrets.edn. The voice-id can be obtained from their playground.
I've also updated core.async.flow to the latest commit (88a7971196cd41fbc921df3f4c36a004a3f974d6).
Two changes were necessary - adding the arity-2
:transformfunctions which just return the state andstep-processis no longer needed (clojure/core.async@8bd11b7).