-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add banner system and TTY detection for CLI output (PR-01) #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implements Phase 1 of CLI Output Enhancement with TTY-aware banner display. New files: - output/banner.go: ASCII art banner with version/license display - output/banner_test.go: 100% test coverage for banner functionality - output/tty.go: TTY detection using golang.org/x/term - output/tty_test.go: 100% test coverage for TTY detection Modified files: - output/logger.go: Add isTTY field and IsTTY()/GetWriter() methods - output/logger_test.go: Tests for new logger methods - cmd/root.go: Add --no-banner persistent flag - cmd/scan.go: Display banner on scan command startup - cmd/ci.go: Display banner on ci command startup - main_test.go: Update help output test with --no-banner flag Dependencies added: - github.com/common-nighthawk/go-figure: ASCII art generation - golang.org/x/term: TTY detection and terminal capabilities Features: - Smart banner display (full ASCII art in TTY, hidden in pipes/CI) - --no-banner flag to disable banner display - Automatic TTY detection for all logger instances - 97% test coverage for output package Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
SafeDep Report SummaryPackage Details
This report is generated by SafeDep Github App |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 80.25% 80.25% -0.01%
==========================================
Files 99 101 +2
Lines 10992 11051 +59
==========================================
+ Hits 8822 8869 +47
- Misses 1819 1830 +11
- Partials 351 352 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|


Summary
Adds an ASCII art banner with TTY detection to improve CLI user experience. The banner displays only when outputting to a terminal and can be disabled with
--no-banner.Why this change?
--no-bannerflag and CI environmentsChanges
go-figurelibrarygolang.org/x/term--no-bannerglobal flagTesting
Related
Part of CLI Output Enhancement initiative (PR-01 of 4)
🤖 Generated with Claude Code