-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add progress bars for scan/CI operations (PR-02) #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SafeDep Report SummaryPackage Details
This report is generated by SafeDep Github App |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 80.25% 79.97% -0.29%
==========================================
Files 101 101
Lines 11051 11114 +63
==========================================
+ Hits 8869 8888 +19
- Misses 1830 1874 +44
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Implements Phase 1 - Step 2 of CLI Output Enhancement with TTY-aware progress bars. Modified files: - output/logger.go: Add progress bar support with progressBar and showProgress fields - output/logger_test.go: Add comprehensive tests for progress bar functionality - cmd/scan.go: Integrate progress bars for graph building, module registry, callgraph, and rule execution - cmd/ci.go: Integrate progress bars for all CI operations Dependencies added: - github.com/schollz/progressbar/v3: Native Go progress bar library Features: - Indeterminate progress bars (spinners) for long-running operations - Determinate progress bars with percentages for rule execution - TTY-aware automatic fallback to simple text messages in non-TTY environments - Zero impact on CI/CD pipelines (progress bars hidden in pipes) - StartProgress, UpdateProgress, FinishProgress, and SetProgressDescription methods - IsProgressEnabled method for checking progress bar availability Progress bars added for: - Building code graph - Building module registry - Building callgraph - Loading rules - Executing rules (with per-rule progress updates) Test coverage: 94.6% for output package (all progress bar methods tested) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
0e540a3 to
997f4be
Compare


Summary
Adds visual progress bars for long-running operations using
schollz/progressbar/v3. Progress bars display for graph building, callgraph construction, module registry, and rule execution.Why this change?
Changes
progressbar/v3dependencyStartProgress(description, total)- Begin progress trackingUpdateProgress(delta)- Increment progress counterFinishProgress()- Complete and clear progress barSetProgressDescription(desc)- Update progress messageTesting
Stack
🤖 Generated with Claude Code