Skip to content

chore(deps): update winnow requirement from 0.7.0 to 1.0.1#125

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/cargo/winnow-1.0.1
Closed

chore(deps): update winnow requirement from 0.7.0 to 1.0.1#125
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/cargo/winnow-1.0.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 6, 2026

Updates the requirements on winnow to permit the latest version.

Changelog

Sourced from winnow's changelog.

[1.0.1] - 2026-03-30

Documentation

  • Ensure macros are visible at winnow::combinator

[1.0.0] - 2026-03-17

Note: going to v1 is more a reflection of the rate of churn in Winnow's API than the quality of previous releases or any statement against future breaking changes.

Migration Guide

  1. Update to latest v0.7 release
  2. Resolve deprecations
  3. Upgrade to v1
  4. Add ascii, binary, or parser features as needed
  5. Break tuples into tuples-of-tuples as needed

Compatibility

  • Added parser, ascii, and binary feature gates to improve build times
  • Reduce 'impl ContainsToken for Tuple' to 10 elements to improve build times
  • Reduce 'impl Alt for Tuple' to 10 elements to improve build times
  • Reduce 'impl Parser for Tuple' to 10 elements to improve build times
  • Replaced (I, usize) with binary::bits::Bits to clarify intent
  • Moved BitOffsets from stream to binary::bits to consolidate the API
  • Make iterator impure like parsers
  • Replace Stream::raw with Stream::trace
  • Remove deprecated APIs

Performance

Build time

  • Reduce macro-generated code
  • Split off parser, ascii, and binary features

Runtime

  • Optimize hex_uint

Features

  • Add Parser::parse_iter

Fixes

  • Export Needed in stream
  • Correct trace for oct_digit1
  • Allow escaped into a Cow
  • Accept a parser for escaped, take_escaped control character for not-quite unicode parsing

... (truncated)

Commits
  • 9015572 chore: Release
  • ae8d6b0 docs: Update changelog
  • 1868f05 Merge pull request #902 from epage/docs
  • bad0c28 docs: Fix macro exporting
  • 1b9c86a docs(design): Cover performance
  • e30e516 docs(design): Further expand
  • 4737ea4 docs(contrib): Fix design link
  • adaabb5 docs(design): Adjust casing for consistency
  • 98469bd docs(design): Expand on Parser design
  • 150b63c docs(design): Discuss API evolution
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [winnow](https://github.com/winnow-rs/winnow) to permit the latest version.
- [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md)
- [Commits](winnow-rs/winnow@v0.7.0...v1.0.1)

---
updated-dependencies:
- dependency-name: winnow
  dependency-version: 1.0.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2026

Labels

The following labels could not be found: rust. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 6, 2026
okhsl = { version = "1.0.1", optional = true }
unicode_categories = "0.1.1"
winnow = { version = "0.7.0", features = ["simd"] }
winnow = { version = "1.0.1", features = ["simd"] }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Missing required feature flag for winnow 1.0

The ascii feature must be enabled for the code to compile. Winnow 1.0 split functionality into feature gates, and winnow::ascii APIs (used in src/tokenizer.rs:3) now require the ascii feature.

Suggested change
winnow = { version = "1.0.1", features = ["simd"] }
winnow = { version = "1.0.1", features = ["simd", "ascii"] }

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their changelog made me think that as well, but that feature is enabled by default. The upgrade guide in the changelog was not particularly useful, unfortunately. I tried upgrading this last night and ended up bashing my head figuratively.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 6, 2026

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
Cargo.toml 23 Missing ascii feature flag for winnow 1.0 - causes compile failure
Other Observations (not in diff)

No additional issues found in unchanged code.

Files Reviewed (2 files)
  • Cargo.toml - 1 issue: Missing feature flag
  • src/tokenizer.rs - No issues (code unchanged, uses winnow::ascii and winnow::token APIs)

Fix these issues in Kilo Cloud


Reviewed by kimi-k2.5-0127 · 163,164 tokens

@shssoichiro
Copy link
Copy Markdown
Owner

@dependabot ignore this major version

This upgrade requires manual intervention due to breaking changes on the alt combinator--it now limits to 10 items, and we have a usage that takes 11.

@dependabot dependabot bot closed this Apr 6, 2026
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2026

OK, I won't notify you about version 1.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/cargo/winnow-1.0.1 branch April 6, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant