chore(deps): update winnow requirement from 0.7.0 to 1.0.1#125
chore(deps): update winnow requirement from 0.7.0 to 1.0.1#125dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Updates the requirements on [winnow](https://github.com/winnow-rs/winnow) to permit the latest version. - [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md) - [Commits](winnow-rs/winnow@v0.7.0...v1.0.1) --- updated-dependencies: - dependency-name: winnow dependency-version: 1.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
| okhsl = { version = "1.0.1", optional = true } | ||
| unicode_categories = "0.1.1" | ||
| winnow = { version = "0.7.0", features = ["simd"] } | ||
| winnow = { version = "1.0.1", features = ["simd"] } |
There was a problem hiding this comment.
CRITICAL: Missing required feature flag for winnow 1.0
The ascii feature must be enabled for the code to compile. Winnow 1.0 split functionality into feature gates, and winnow::ascii APIs (used in src/tokenizer.rs:3) now require the ascii feature.
| winnow = { version = "1.0.1", features = ["simd"] } | |
| winnow = { version = "1.0.1", features = ["simd", "ascii"] } |
There was a problem hiding this comment.
Their changelog made me think that as well, but that feature is enabled by default. The upgrade guide in the changelog was not particularly useful, unfortunately. I tried upgrading this last night and ended up bashing my head figuratively.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)No additional issues found in unchanged code. Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by kimi-k2.5-0127 · 163,164 tokens |
|
@dependabot ignore this major version This upgrade requires manual intervention due to breaking changes on the |
|
OK, I won't notify you about version 1.x.x again, unless you re-open this PR. |
Updates the requirements on winnow to permit the latest version.
Changelog
Sourced from winnow's changelog.
... (truncated)
Commits
9015572chore: Releaseae8d6b0docs: Update changelog1868f05Merge pull request #902 from epage/docsbad0c28docs: Fix macro exporting1b9c86adocs(design): Cover performancee30e516docs(design): Further expand4737ea4docs(contrib): Fix design linkadaabb5docs(design): Adjust casing for consistency98469bddocs(design): Expand on Parser design150b63cdocs(design): Discuss API evolutionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)