Skip to content

chore(deps): update winnow requirement from 0.7.0 to 1.0.1 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps): update winnow requirement from 0.7.0 to 1.0.1 #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ anstream = { version = "1.0.0", optional = true }
anstyle = { version = "1.0.13", optional = true }
okhsl = { version = "1.0.1", optional = true }
unicode_categories = "0.1.1"
winnow = { version = "0.7.0", features = ["simd"] }
winnow = { version = "1.0.1", features = ["simd"] }
Copy link
Copy Markdown

@kilo-code-bot kilo-code-bot bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Missing required feature flag for winnow 1.0

The ascii feature must be enabled for the code to compile. Winnow 1.0 split functionality into feature gates, and winnow::ascii APIs (used in src/tokenizer.rs:3) now require the ascii feature.

Suggested change
winnow = { version = "1.0.1", features = ["simd"] }
winnow = { version = "1.0.1", features = ["simd", "ascii"] }

Copy link
Copy Markdown
Owner

@shssoichiro shssoichiro Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their changelog made me think that as well, but that feature is enabled by default. The upgrade guide in the changelog was not particularly useful, unfortunately. I tried upgrading this last night and ended up bashing my head figuratively.


[dev-dependencies]
criterion = "0.7"
Expand Down
Loading