Skip to content

test(filtered-search): harden e2e test #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spike-rabbit wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(filtered-search): harden e2e test #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions playwright/e2e/element-examples/si-filtered-search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ test.describe('filtered search', () => {
// remove score criterion
await page.keyboard.press('Shift+Tab');
await page.keyboard.press('Shift+Tab');
await expect(page.locator('.criterion-value-text', { hasText: 'Good' })).toBeFocused();
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better test robustness, it's good practice to use more specific locators. Chaining locators can help scope the search and prevent potential flakiness if other elements with similar properties are added to the page in the future. You could scope this locator to the 'Score' pill to make it more specific.

Suggested change
await expect(page.locator('.criterion-value-text', { hasText: 'Good' })).toBeFocused();
await expect(page.locator('.pill-group', { hasText: 'Score' }).locator('.criterion-value-text', { hasText: 'Good' })).toBeFocused();

await page.keyboard.press('Enter');
await expect(
page.locator('.pill-group', { hasText: 'Score' }).getByRole('combobox')
Expand Down
Loading