Enable text selection starting from emoji#7489
Open
david12341235 wants to merge 2 commits intosignalapp:mainfrom
Open
Enable text selection starting from emoji#7489david12341235 wants to merge 2 commits intosignalapp:mainfrom
david12341235 wants to merge 2 commits intosignalapp:mainfrom
Conversation
Member
|
I think this would improve selection in more places actually, like conversation titles and descriptions. In retrospect, I think we can just make the .FunInlineEmoji {
/* ... */
- user-select: none;
+ // We want to inherit here since most usage of <Emojify> should not be
+ // selectable, but in cases like messages, conversation titles/descriptions,
+ // etc we want emoji to be selectable within the surrounding text.
+ // If the root `.FunInlineEmoji` element isn't selectable, then selection
+ // can't start on the emoji itself.
+ user-select: inherit;
}
|
Author
|
@jamiebuilds-signal sure thing, just made the changes (and signed the Contributor License Agreement). Thanks! |
…tRenderer. Allows user text selection to start on an emoji. Fixes signalapp#7206
81cb339 to
6337742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Previously, text selection in conversation history would fail if selection started on an emoji, as described in #7206. This change addresses the issue with a small CSS style addition.
Manual testing - sent messages containing emojis with two standalone profiles and reproduced. Tested on other occurrences of emojis across the app such as story reactions and Chats sidebar previews to ensure unintended selection isn't possible.
No new tests, ran on OSX Sequoia 15.6.1, no other devices tested.
Look forward to contributing more, thought I'd start with a quick fix to get the hang of things :) thanks for your work Signal team.