Skip to content

Fix Launch Screen Background being in LightMode in DarkMode#5943

Closed
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown:#5937-LightModeFlashOnStartup
Closed

Fix Launch Screen Background being in LightMode in DarkMode#5943
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown:#5937-LightModeFlashOnStartup

Conversation

@MarlowBrown
Copy link

@MarlowBrown MarlowBrown commented Jan 22, 2025

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16, iOS 18.2

Description

Changed the background color of the Launch Screen to systemBackground color because Signal/BackgroundLevels/backgroundbase was missing. This fixes #5937.

I tested my fix by running the application in light and dark modes to ensure the correct colors for each respective mode.

… color before Signal/BackgroundLevels/backgroundbase was missing.

(cherry picked from commit 12e70c9cab1f343b3288be85dc7507b6057ad175)
@MarlowBrown MarlowBrown mentioned this pull request Jan 22, 2025
3 tasks
@sashaweiss-signal
Copy link
Contributor

Hey @MarlowBrown, thanks for the contribution and for signing the CLA. The way we merge public PRs is by re-opening the PR in our private repo where we do our primary development, making sure the commit includes your name and email for attribution purposes. Would you mind sharing the name/email you'd like associated with the commit I create in our private repo? If you'd prefer, feel free to send those to me directly at sasha@signal.org.

@sashaweiss-signal
Copy link
Contributor

(I saw you had a number of PRs open – I'll plan to use the same name/email for all of them that we decide to merge!)

@MarlowBrown
Copy link
Author

Hey @sashaweiss-signal, I send you an email with my attribution information.

@sashaweiss-signal
Copy link
Contributor

This was merged internally as 17afb854c3, which should become public in a week or two with an upcoming release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants