Fix Launch Screen Background being in LightMode in DarkMode#5943
Closed
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Closed
Fix Launch Screen Background being in LightMode in DarkMode#5943MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Conversation
… color before Signal/BackgroundLevels/backgroundbase was missing. (cherry picked from commit 12e70c9cab1f343b3288be85dc7507b6057ad175)
3 tasks
Contributor
|
Hey @MarlowBrown, thanks for the contribution and for signing the CLA. The way we merge public PRs is by re-opening the PR in our private repo where we do our primary development, making sure the commit includes your name and email for attribution purposes. Would you mind sharing the name/email you'd like associated with the commit I create in our private repo? If you'd prefer, feel free to send those to me directly at sasha@signal.org. |
Contributor
|
(I saw you had a number of PRs open – I'll plan to use the same name/email for all of them that we decide to merge!) |
6 tasks
Author
|
Hey @sashaweiss-signal, I send you an email with my attribution information. |
Contributor
|
This was merged internally as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Changed the background color of the Launch Screen to systemBackground color because Signal/BackgroundLevels/backgroundbase was missing. This
fixes #5937.I tested my fix by running the application in light and dark modes to ensure the correct colors for each respective mode.