Add regression test for unaligned checkpoint sync with payload pruning #8458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This adds a regression test for sigp#8426. When `prune_payloads` is enabled, unaligned checkpoint syncs (where the anchor block is older than the checkpoint state) were previously failing to import the anchor block's execution payload. The new test `reproduction_unaligned_checkpoint_sync_pruned_payload` reproduces this scenario and asserts that the Beacon Chain initializes successfully (which confirms the anchor payload was correctly loaded).
Andrurachi
force-pushed
the
test-unaligned-sync-repro-8426
branch
from
f88fbc3 to
75772e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #8426
Proposed Changes
Added a new regression test:
reproduction_unaligned_checkpoint_sync_pruned_payload.This test reproduces the bug where unaligned checkpoint syncs (skipped slots at epoch boundaries) fail to import the anchor block's execution payload when
prune_payloadsis enabled.The test simulates the failure mode by:
It asserts that the Beacon Chain builds successfully (previously it panicked with
MissingFullBlockExecutionPayloadPruned), confirming the fix logic intry_get_full_block.