Skip to content

[GHA] Add install-scripts to installer upload trigger#4108

Merged
imnasnainaec merged 2 commits intomasterfrom
net-installer-trigger
Jan 26, 2026
Merged

[GHA] Add install-scripts to installer upload trigger#4108
imnasnainaec merged 2 commits intomasterfrom
net-installer-trigger

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 23, 2026

Follow-up to #4107


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Updated installer workflow automation to improve deployment trigger conditions.

✏️ Tip: You can customize this high-level summary in your review settings.

@imnasnainaec imnasnainaec self-assigned this Jan 23, 2026
@imnasnainaec imnasnainaec added the 🟥High High-priority PR: please review this asap! label Jan 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The installer workflow file now triggers on changes to either installer/README.md or any file matching deploy/scripts/.*install-combine.* pattern, expanding the files that initiate the workflow beyond the original single file path.

Changes

Cohort / File(s) Summary
Workflow trigger pattern expansion
.github/workflows/installer.yml
Extended changed-file detection pattern to match installer/README.md OR deploy/scripts/.*install-combine.* instead of only the former, broadening workflow trigger conditions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • jasonleenaylor

Poem

🐰 A trigger grows wider, a path splits in two,
Installer and scripts now both wake the queue,
One pattern expands where before there was one,
More paths to deploy—the workflow's begun! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding install-scripts to the installer upload trigger in the GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 23, 2026
@imnasnainaec imnasnainaec requested a review from Copilot January 23, 2026 23:18
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (c36142c) to head (ae3f6fb).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4108   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         295      295           
  Lines       10911    10911           
  Branches     1366     1366           
=======================================
  Hits         8175     8175           
  Misses       2341     2341           
  Partials      395      395           
Flag Coverage Δ
backend 86.46% <ø> (ø)
frontend 66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to #4107 and extends the installer workflow to trigger README PDF uploads not only when the README file changes, but also when installation scripts in deploy/scripts/ are modified.

Changes:

  • Modified the grep pattern in the make_readme job to detect changes in both installer/README.md and installation scripts matching deploy/scripts/*install-combine*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@imnasnainaec
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).

@imnasnainaec imnasnainaec merged commit 2bb9ebe into master Jan 26, 2026
29 checks passed
@imnasnainaec imnasnainaec deleted the net-installer-trigger branch January 26, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment github_actions Pull requests that update GitHub Actions code 🟥High High-priority PR: please review this asap!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants