[GHA] Add install-scripts to installer upload trigger#4108
[GHA] Add install-scripts to installer upload trigger#4108imnasnainaec merged 2 commits intomasterfrom
Conversation
📝 WalkthroughWalkthroughThe installer workflow file now triggers on changes to either Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4108 +/- ##
=======================================
Coverage 74.92% 74.92%
=======================================
Files 295 295
Lines 10911 10911
Branches 1366 1366
=======================================
Hits 8175 8175
Misses 2341 2341
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to #4107 and extends the installer workflow to trigger README PDF uploads not only when the README file changes, but also when installation scripts in deploy/scripts/ are modified.
Changes:
- Modified the grep pattern in the
make_readmejob to detect changes in bothinstaller/README.mdand installation scripts matchingdeploy/scripts/*install-combine*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).
Follow-up to #4107
This change is
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.