Skip to content

Bug/1555 auto update check uses hours component of timespan rather than totalhours #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Bug/1555 auto update check uses hours component of timespan rather than totalhours #1556

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5aa16f
Add logging to ShouldCheckForUpdate
myieye Mar 24, 2025
fc6654a
Use TotalHours instead of Hours or UpdateChecking
myieye Mar 24, 2025
5f72482
Decrease update check to 8 hours
myieye Mar 24, 2025
3656160
Reference correct env-var in log
myieye Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions backend/FwLite/FwLiteMaui/Platforms/Windows/AppUpdateService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,17 +202,26 @@ private async Task<ShouldUpdateResponse> ShouldUpdate()
private bool ShouldCheckForUpdate()
{
if (ValidPositiveEnvVarValues.Contains(Environment.GetEnvironmentVariable(ForceUpdateCheckEnvVar) ?? ""))
{
logger.LogInformation("Should check for update based on env var {EnvVar}", PreventUpdateCheckEnvVar);
return true;
}
var lastChecked = preferences.Get(LastUpdateCheck, DateTime.MinValue);
var timeSinceLastCheck = DateTime.UtcNow - lastChecked;
//if last checked is in the future (should never happen), then we want to reset the time and check again
if (timeSinceLastCheck.Hours < -1)
if (timeSinceLastCheck.TotalHours < -1)
{
preferences.Set(LastUpdateCheck, DateTime.UtcNow);
logger.LogInformation("Should check for update, because last check was in the future: {LastCheck}", lastChecked);
return true;
}
if (timeSinceLastCheck.Hours < 20) return false;
if (timeSinceLastCheck.TotalHours < 8)
{
logger.LogInformation("Should not check for update, because last check was too recent: {LastCheck}", lastChecked);
return false;
}
preferences.Set(LastUpdateCheck, DateTime.UtcNow);
logger.LogInformation("Should check for update based on last check time: {LastCheck}", lastChecked);
return true;
}

Expand Down
Loading