Skip to content

Fail build if any i18n strings were not extracted #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 31, 2025
Merged

Fail build if any i18n strings were not extracted #1864

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
578825d
Fail build if any i18n strings were not extracted
rmunn Jul 31, 2025
64c2911
Fix quoting in "Please run pnpm i18n:extract" line
rmunn Jul 31, 2025
e058614
Printing blank lines gets omitted in GHA logs
rmunn Jul 31, 2025
60d484f
Exit verify-i18n step on any unexpected failures
rmunn Jul 31, 2025
76b692f
Much simpler test for unextracted strings
rmunn Jul 31, 2025
3801ace
Run i18n checking step *before* Playwright
rmunn Jul 31, 2025
0169cf8
Back to shell script, lingui doesn't do what we need
rmunn Jul 31, 2025
82c4f3c
Fix partially-missing script
rmunn Jul 31, 2025
0225252
stop running lingui extract twice
hahn-kev Jul 31, 2025
69fb096
update locales
hahn-kev Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/fw-lite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,28 @@ jobs:
- name: Run snapshot tests
working-directory: frontend/viewer
run: task playwright-test-standalone
- name: Ensure all i18n strings have been extracted
working-directory: frontend/viewer
shell: bash
run: |
set -e
rm -f src/locales/en.po.old
cp src/locales/en.po src/locales/en.po.old
pnpm i18n:extract
DIFFCOUNT=$(diff -u src/locales/en.po{.old,} | grep '+msgid' | wc -l)
if [ $DIFFCOUNT -gt 0 ]; then
# Unextracted strings found, fail the build
echo '***'
echo $DIFFCOUNT unextracted strings found:
echo '***'
diff -u src/locales/en.po{.old,} | grep '+msgid' | cut -c2-
echo '***'
echo Please run "'"pnpm i18n:extract"'" and commit the new src/locales/en.po file
exit 1
fi

rm -f src/locales/en.po.old
exit 0

- name: Build viewer
working-directory: frontend/viewer
Expand Down
Loading