Conversation
loichuder
approved these changes
Jan 31, 2025
axelboc
force-pushed
the
h5grove-bigint
branch
from
121b5c1 to
4fef55e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the split of
NumericTypeintoIntegerTypeandFloatTypein #1736, I'm doing the same withArrayType, which was covering twoH5T_class_tvalues:H5T_ARRAYandH5T_VLEN.Turns out this was making things more complicated than they needed to be... So now we have two separate dtypes:
VLenTypeandArrayType.Note that nothing changes in the UI or in the provider snapshots, since the enum value
DTypeClass.VLendoesn't change: it remains "Array (variable-length)".