Conversation
sudosubin
requested review from
KimHunJin,
ProdMoon,
azure-553,
danmin20,
froggy1014,
frontman-git,
hy57in,
jiji-hoon96,
joel-jo-querypie,
saseungmin and
synuns
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sudosubin
force-pushed
the
feature/image-change
branch
from
42ec8bb to
a38bedb
Compare
froggy1014
approved these changes
Apr 24, 2025
| const row = it['_rawData']; | ||
|
|
||
| const thumbnailId = (row[12] ?? '').match(/\/d\/(.*?)\/view/)?.[1] ?? ''; | ||
| const key = row[0] ?? Math.random().toString(36).substring(2, 15); |
| <> | ||
| {renderFillImage( | ||
| <NextImage | ||
| key={src} |
refactor: improve image fallback handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
스크립트 수정
기존에는 사용자 데이터의
id를 결정할 때??를 이용해서id가 존재하지 않으면 무작위 문자열을 생성해 사용했었는데,??는 nullish coalescing operator로 값이null이거나undefined일 떄에만 동작합니다. 실제로는 비어있는 셀에서는 빈 문자열이 응답으로 내려와 이 로직을 타지 않는 문제가 있었고,||operator로 변경했습니다.참고로 현재는 사용자 데이터 시트에
id셀을 추가하여 값을 추가해두어서id값이 잘 결정되고 있습니다.이미지 렌더링 수정
Image의
src가 변경될 때, 새로운 이미지를 완전히 로드하기 전까지 이미지가 유지되다가 뒤늦게 변경되는 현상이 있었습니다.key값을src와 동일하게 넣어서 reconciliation에 따라서 다시 즉시 렌더링 되고, 그 과정에서 기존 이미지가 계속 유지되지 않도록 수정했습니다.CleanShot.2025-04-24.at.20.43.09.mp4
CleanShot.2025-04-24.at.20.42.29.mp4